Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node-core): cleanup + prep for server v2 #1561

Merged
merged 4 commits into from
Jun 22, 2024
Merged

chore(node-core): cleanup + prep for server v2 #1561

merged 4 commits into from
Jun 22, 2024

Conversation

archbear
Copy link
Contributor

No description provided.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 21, 2024 •
edited
Loading

Warning

Rate limit exceeded

@archbear has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 56 minutes and 10 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 9285fe6 and 68011e3.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

itsdevbear
itsdevbear reviewed Jun 21, 2024
View reviewed changes
mod/cli/pkg/config/client.go
@@ -0,0 +1,31 @@
// SPDX-License-Identifier: BUSL-1.1
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was your plan? would a client folder make more sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh no pref i just moved this cause i hate utils.go as a concept and its like just a convenience func for cosmos client config

@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 25.81%. Comparing base (9285fe6) to head (68011e3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
+ Coverage   25.77%   25.81%   +0.03%     
==========================================
  Files         260      259       -1     
  Lines       11665    11649      -16     
  Branches       18       18              
==========================================
  Hits         3007     3007              
+ Misses       8491     8475      -16     
  Partials      167      167
Files Coverage Δ
mod/cli/pkg/commands/setup.go 0.00% <ø> (ø)
mod/cli/pkg/builder/builder.go 0.00% <0.00%> (ø)
mod/cli/pkg/builder/options.go 0.00% <0.00%> (ø)
mod/cli/pkg/commands/root.go 0.00% <0.00%> (ø)
mod/cli/pkg/components/client_context.go 0.00% <0.00%> (ø)
mod/node-core/pkg/builder/baseapp_options.go 0.00% <0.00%> (ø)
mod/node-core/pkg/builder/options.go 0.00% <0.00%> (ø)
mod/cli/pkg/config/client.go 0.00% <0.00%> (ø)
mod/node-core/pkg/node/node.go 0.00% <0.00%> (ø)
beacond/cmd/main.go 0.00% <0.00%> (ø)
... and 1 more

@itsdevbear itsdevbear merged commit 077aa37 into main Jun 22, 2024
17 checks passed
@itsdevbear itsdevbear deleted the my-humble-anode branch June 22, 2024 03:15
@itsdevbear
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdevbear itsdevbear itsdevbear left review comments

@ocnc ocnc Awaiting requested review from ocnc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archbear @itsdevbear